[WIP] Windows support #481
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…, replace 0.0.0.0 with 127.0.0.1 for auth
…, replace 0.0.0.0 with 127.0.0.1 for auth
dalazx
reviewed
Feb 8, 2019
| image: Visual Studio 2015 | ||
|
|
||
| environment: | ||
| # ensure Python 3.6 is first in path |
There was a problem hiding this comment.
minor. 3.6 or 3.7? the path below has Python37.
dalazx
reviewed
Feb 8, 2019
| @@ -163,6 +164,10 @@ def help(ctx: click.Context, command: Sequence[str]) -> None: | |||
|
|
|||
|
|
|||
| def main(args: Optional[List[str]] = None) -> None: | |||
| if sys.platform == "win32": | |||
There was a problem hiding this comment.
minor. should we extract a constant and reuse throughout?
There was a problem hiding this comment.
The constant is obvious, send contained, and will never change.
I think using strings for such cases is pretty satisfactory.
|
Implemented by #548 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the following changes: