Common way of parsing images: image:latest is forbidden

[atemate]

Sorry for such a big PR: we need to support all the cases of local images, remote images in docker-hub and remote images in neuro-registry:

$ neuro image push ubuntu
Using local image 'ubuntu:latest'
Using remote image 'image://artemyushkovskiy/ubuntu:latest'
...

$ neuro image push image://~/ubuntu
Invalid local image 'image://~/ubuntu': scheme 'image://' is not allowed for local images
...

$ neuro image pull image://~/ubuntu
Using remote image 'image://artemyushkovskiy/ubuntu:latest'
Using local image 'ubuntu:latest'
...

$ neuro image pull ubuntu
Invalid remote image 'ubuntu': scheme 'image://' is required
...

$ neuro submit ubuntu
Using image 'ubuntu:latest'
...

$ neuro submit image://~/ubuntu
Using image 'image://artemyushkovskiy/ubuntu:latest'
...

$ neuro submit image:ubuntu
Using image 'image://artemyushkovskiy/ubuntu:latest'
...

$ neuro submit image://chuck/ubuntu
Using image 'image://chuck/ubuntu:latest'
...

[atemate]

The corner case neuro submit image:v1 is resolved to image://~/v1:latest

[atemate]

maybe we need more tests on the commands (@command) itself (pull, push, submit), because e2e don't cover all the cases

[codecov]

Codecov Report

Merging #539 into master will increase coverage by 0.3%.
The diff coverage is 100%.

@@            Coverage Diff            @@
##           master     #539     +/-   ##
=========================================
+ Coverage   91.46%   91.77%   +0.3%     
=========================================
  Files          39       40      +1     
  Lines        2941     3014     +73     
  Branches      384      391      +7     
=========================================
+ Hits         2690     2766     +76     
+ Misses        188      187      -1     
+ Partials       63       61      -2

Impacted Files	Coverage Δ
python/neuromation/cli/model.py	87.3% <ø> (ø)	⬆️
python/neuromation/client/__init__.py	98.46% <100%> (+0.02%)	⬆️
python/neuromation/client/parsing_utils.py	100% <100%> (ø)
python/neuromation/cli/image.py	100% <100%> (+5.88%)	⬆️
python/neuromation/client/images.py	99.04% <100%> (-0.1%)	⬇️
python/neuromation/cli/job.py	96.96% <100%> (+0.09%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df9ead5...d4c4972. Read the comment docs.

[asvetlov]

I prefer this variant.
image:abc is a URL with image scheme, and abc is for an image name.
BTW, docker hub has no image registered: https://hub.docker.com/_/image returns 404 Not Found

[atemate]

I prefer image:latest to be image://~/latest as well, because thus we follow our own pattern of using image: as scheme and not as name. Plus, indeed there's no such image latest in docker.io.

[asvetlov]

We can forbid the image named latest for image: scheme explicitly to avoid confusion.

[atemate]

We can forbid the image named latest for image: scheme explicitly to avoid confusion.

Good idea! added this check:

$ neuro job submit image:latest
Invalid remote image 'image:latest': ambiguous value: valid as both local and remote image name

[dalazx]

@ajuszkowski please resolve the conflict.

[atemate]

rebased