Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Common way of parsing images. image:latest is docker.io/library/image:latest #545

Closed
wants to merge 20 commits into from

Conversation

atemate
Copy link
Contributor

@atemate atemate commented Feb 21, 2019

Alternative version of PR #539 with image:latest is docker.io/library/image:latest by default

@atemate atemate force-pushed the ay/image-job-submit-default-docker branch from 7ee91cf to fac2995 Compare February 21, 2019 15:18
@atemate atemate changed the title Common way of parsing images: image:latest is docker.io/library/image:latest Common way of parsing images. image:latest is docker.io/library/image:latest Feb 21, 2019
@codecov
Copy link

codecov bot commented Feb 21, 2019

Codecov Report

Merging #545 into master will increase coverage by 0.04%.
The diff coverage is 96.09%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #545      +/-   ##
==========================================
+ Coverage   91.46%   91.51%   +0.04%     
==========================================
  Files          40       41       +1     
  Lines        2929     2957      +28     
  Branches      387      385       -2     
==========================================
+ Hits         2679     2706      +27     
- Misses        188      192       +4     
+ Partials       62       59       -3
Impacted Files Coverage Δ
python/neuromation/cli/model.py 87.69% <ø> (ø) ⬆️
python/neuromation/client/url_utils.py 100% <ø> (ø) ⬆️
python/neuromation/client/__init__.py 98.3% <100%> (+0.02%) ⬆️
python/neuromation/client/images.py 99.04% <100%> (-0.1%) ⬇️
python/neuromation/cli/job.py 97.1% <100%> (+0.08%) ⬆️
python/neuromation/cli/image.py 93.22% <90.47%> (-1.23%) ⬇️
python/neuromation/client/parsing_utils.py 95.94% <95.94%> (ø)
python/neuromation/cli/main.py 53.84% <0%> (-5.08%) ⬇️
python/neuromation/cli/formatters/config.py 100% <0%> (ø) ⬆️
python/neuromation/cli/formatters/jobs.py 100% <0%> (ø) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b81f265...fac2995. Read the comment docs.

@atemate
Copy link
Contributor Author

atemate commented Feb 26, 2019

closing with respect to PR #539

@atemate atemate closed this Feb 26, 2019
@atemate atemate deleted the ay/image-job-submit-default-docker branch February 26, 2019 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants