Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make api SecretFile class public #1714

Merged
merged 3 commits into from
Sep 3, 2020
Merged

Make api SecretFile class public #1714

merged 3 commits into from
Sep 3, 2020

Conversation

asvetlov
Copy link
Contributor

@asvetlov asvetlov commented Sep 3, 2020

No description provided.

@asvetlov asvetlov changed the title Public names Make api SecretFile class public Sep 3, 2020
@codecov
Copy link

codecov bot commented Sep 3, 2020

Codecov Report

Merging #1714 into master will decrease coverage by 10.93%.
The diff coverage is 93.75%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #1714       +/-   ##
===========================================
- Coverage   88.04%   77.10%   -10.94%     
===========================================
  Files          59       59               
  Lines        8830     8849       +19     
  Branches     1438     1440        +2     
===========================================
- Hits         7774     6823      -951     
- Misses        799     1825     +1026     
+ Partials      257      201       -56     
Flag Coverage Δ
#e2e ?
#unit 77.10% <93.75%> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
neuromation/api/images.py 92.85% <93.75%> (-1.96%) ⬇️
neuromation/cli/blob_storage.py 29.09% <0.00%> (-53.34%) ⬇️
neuromation/cli/ael.py 15.98% <0.00%> (-49.75%) ⬇️
neuromation/cli/storage.py 31.57% <0.00%> (-48.61%) ⬇️
neuromation/cli/share.py 53.52% <0.00%> (-46.48%) ⬇️
neuromation/cli/image.py 55.73% <0.00%> (-44.27%) ⬇️
neuromation/cli/job.py 52.55% <0.00%> (-32.85%) ⬇️
neuromation/api/users.py 59.13% <0.00%> (-27.96%) ⬇️
neuromation/cli/root.py 65.16% <0.00%> (-24.52%) ⬇️
neuromation/api/parser.py 76.00% <0.00%> (-20.00%) ⬇️
... and 20 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 39290c6...9918a06. Read the comment docs.

@asvetlov asvetlov merged commit 7e8a7fc into master Sep 3, 2020
@asvetlov asvetlov deleted the public-names branch September 3, 2020 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant