Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make api SecretFile class public #1714

Merged
merged 3 commits into from
Sep 3, 2020
Merged

Make api SecretFile class public #1714

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c11c8f9
Add SecretFile to public exposed names
asvetlov Sep 3, 2020
48b06e8
Reorganize imports
asvetlov Sep 3, 2020
9918a06
Add changelog
asvetlov Sep 3, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.D/1714.bugfix
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Make `neuromation.api.SecretFile` class public
4 changes: 2 additions & 2 deletions neuromation/api/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,9 +52,8 @@
JobTelemetry,
Resources,
StdStream,
Volume,
)
from .parser import Parser
from .parser import Parser, SecretFile, Volume
from .parsing_utils import LocalImage, RemoteImage, TagOption
from .plugins import PluginManager
from .secrets import Secret, Secrets
Expand Down Expand Up @@ -131,6 +130,7 @@
"Parser",
"Secrets",
"Secret",
"SecretFile",
"PluginManager",
"find_project_root",
)
Expand Down
2 changes: 1 addition & 1 deletion tests/cli/formatters/test_jobs_formatters.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,9 @@
JobTelemetry,
RemoteImage,
Resources,
SecretFile,
Volume,
)
from neuromation.api.parser import SecretFile
from neuromation.api.parsing_utils import _ImageNameParser
from neuromation.cli.formatters.jobs import (
JobStartProgress,
Expand Down