Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Customize names of ignore files (support .gitignore etc) #1560

Closed
serhiy-storchaka opened this issue Jun 17, 2020 · 2 comments · Fixed by #1561
Closed

Customize names of ignore files (support .gitignore etc) #1560

serhiy-storchaka opened this issue Jun 17, 2020 · 2 comments · Fixed by #1561
Labels
enhancement New feature or request

Comments

@serhiy-storchaka
Copy link
Contributor

Support of .neuroignore files was added in #1446.

We need to add support of other ignore files (e.g. .gitignore) and also an option to disable .neuroignore files.

The proposition is to add option --exclude-from-files to specify a space separated list of ignore files.

  • --exclude-from-files=".neuroignore .gitignore" -- use both .neuroignore and .gitignore.
  • --exclude-from-files=.gitignore -- use only .gitignore.
  • --exclude-from-files= -- do not use any ignore files.

By default .neuroignore is used.

@serhiy-storchaka serhiy-storchaka added the enhancement New feature or request label Jun 17, 2020
@serhiy-storchaka
Copy link
Contributor Author

@asvetlov @YArtem

@atemate
Copy link
Contributor

atemate commented Jun 17, 2020

Good idea to avoid duplication of .neuroignore and .gitignore! If we add the flag neuro cp --exclude-from-files, will the corresponding .neuro.toml entry be automatically supported? Similar to what we have to exclude:

[storage]
cp-exclude = ["*.log"]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants