Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the --exclude-from-files option in "neuro cp". #1561

Merged
merged 6 commits into from
Jun 18, 2020

Conversation

serhiy-storchaka
Copy link
Contributor

Closes #1560.

TODO: Update the API docs (they are outdated).

@codecov
Copy link

codecov bot commented Jun 17, 2020

Codecov Report

Merging #1561 into master will increase coverage by 0.13%.
The diff coverage is 93.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1561      +/-   ##
==========================================
+ Coverage   85.42%   85.55%   +0.13%     
==========================================
  Files          55       55              
  Lines        8307     8322      +15     
  Branches     1363     1367       +4     
==========================================
+ Hits         7096     7120      +24     
+ Misses        953      945       -8     
+ Partials      258      257       -1     
Flag Coverage Δ
#e2e 60.10% <46.66%> (+0.16%) ⬆️
#unit 76.13% <86.66%> (-0.01%) ⬇️
Impacted Files Coverage Δ
neuromation/cli/topics.py 67.44% <ø> (ø)
neuromation/cli/storage.py 80.00% <83.33%> (+0.12%) ⬆️
neuromation/api/blob_storage.py 94.88% <100.00%> (+0.01%) ⬆️
neuromation/api/config.py 92.02% <100.00%> (ø)
neuromation/api/storage.py 95.00% <100.00%> (ø)
neuromation/cli/blob_storage.py 82.42% <100.00%> (+0.21%) ⬆️
neuromation/cli/asyncio_utils.py 64.90% <0.00%> (-0.67%) ⬇️
neuromation/cli/formatters/storage.py 96.21% <0.00%> (ø)
neuromation/cli/ael.py 43.32% <0.00%> (+1.63%) ⬆️
neuromation/cli/main.py 74.52% <0.00%> (+1.91%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 08bb4ff...c31c5e1. Read the comment docs.

Copy link
Contributor

@asvetlov asvetlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
I think the option worth to be added to user config (like life-span or ps-columns)

Copy link
Contributor

@asvetlov asvetlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a few minor text comments.

CHANGELOG.D/1560.feature Show resolved Hide resolved
neuromation/cli/blob_storage.py Outdated Show resolved Hide resolved
neuromation/cli/storage.py Outdated Show resolved Hide resolved
neuromation/cli/topics.py Outdated Show resolved Hide resolved
@serhiy-storchaka serhiy-storchaka merged commit 2eaea8b into master Jun 18, 2020
@serhiy-storchaka serhiy-storchaka deleted the ss/exclude-from-files branch June 18, 2020 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Customize names of ignore files (support .gitignore etc)
2 participants