Replacement PR for #1349 (neuro images ls -l support) #1354

olegstepanov · 2020-02-26T15:56:10Z

Had to recreate PR because Azure failed to run the checks

lgtm-com · 2020-02-26T16:11:54Z

This pull request introduces 1 alert when merging b91d973 into 2a9fb8b - view on LGTM.com

new alerts:

1 for Unused import

serhiy-storchaka

LGTM on green.

I think there may be some issues with formatter.

tests/cli/test_ftable.py

…latform-client-python into long-images-list-2

neuromation/cli/job.py

codecov · 2020-02-27T06:04:44Z

Codecov Report

❗ No coverage uploaded for pull request base (master@2df131d). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #1354   +/-   ##
=========================================
  Coverage          ?   89.16%           
=========================================
  Files             ?       48           
  Lines             ?     6580           
  Branches          ?     1042           
=========================================
  Hits              ?     5867           
  Misses            ?      554           
  Partials          ?      159

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2df131d...008ed50. Read the comment docs.

…latform-client-python into long-images-list-2

asvetlov

Please add CHANGELOG.D record

neuromation/api/parsing_utils.py

…on is not successful

dalazx

the diff does not look good. should be rebased.

asvetlov · 2020-03-02T16:56:19Z

neuromation/cli/formatters/images.py

+
+class LongImagesFormatter(BaseImagesFormatter):
+    def __call__(self, images: Iterable[RemoteImage]) -> Iterable[str]:
+        rows = [[str(image), image.as_docker_url] for image in images]


The last neat: please add the table header, like for neuro ps command.

What would be good headers? 'IMAGE URL', 'DOCKER URL'?

I guess Neuro URL and Docker URL (both capitalized) -- to reflect the fact that the first value should be used with neuro, the second is for docker.

olegstepanov added 6 commits February 25, 2020 18:46

First attempt

8b250fb

Converted repeated code to table()

a3d9b8a

Fixed lint

97fa21d

Removed unnecessary __iter__ call

3f83efe

Removed conversion to table() in storage.py

6c05bb5

Added support for empty input in table()

b91d973

Removed unused import

69ec7c0

serhiy-storchaka approved these changes Feb 26, 2020

View reviewed changes

tests/cli/test_ftable.py Outdated Show resolved Hide resolved

serhiy-storchaka closed this Feb 26, 2020

serhiy-storchaka reopened this Feb 26, 2020

serhiy-storchaka marked this pull request as ready for review February 26, 2020 16:48

olegstepanov added 9 commits February 26, 2020 21:26

First attempt

92c8928

Converted repeated code to table()

fe4c00b

Fixed lint

95645ee

Removed unnecessary __iter__ call

46e0ddf

Removed conversion to table() in storage.py

d7d4af3

Added support for empty input in table()

9cd6c97

Removed unused import

2c8ec62

Merge branch 'long-images-list-2' of https://github.com/neuromation/p…

054c070

…latform-client-python into long-images-list-2

Fixed formatting

16963b3

asvetlov reviewed Feb 26, 2020

View reviewed changes

neuromation/cli/job.py Show resolved Hide resolved

Update neuromation/cli/job.py

6de51e1

asvetlov and others added 6 commits February 27, 2020 16:05

Enable MacOS tests (#1352)

09c6262

First attempt

659ace6

Converted repeated code to table()

ed26342

Fixed lint

f79875a

Removed unnecessary __iter__ call

c8eae9e

Removed conversion to table() in storage.py

736abe6

olegstepanov and others added 9 commits February 28, 2020 13:54

Removed conversion to table() in storage.py

f56db02

Added support for empty input in table()

af2c6cc

Removed unused import

1a210a7

Fixed formatting

fa79b59

Update neuromation/cli/job.py

dd056dc

Merge branch 'long-images-list-2' of https://github.com/neuromation/p…

027a58c

…latform-client-python into long-images-list-2

Added test on 'neuro image ls -l'

7043add

Improved test

59338ee

Fixed lint

2868614

asvetlov requested changes Mar 2, 2020

View reviewed changes

neuromation/api/parsing_utils.py Outdated Show resolved Hide resolved

serhiy-storchaka and others added 15 commits March 2, 2020 18:32

Add the -u option in "neuro acl list" (#1356)

b434958

Add a workaround for bad images in a list. (#1358)

0e36795

Sort 'neuro admin get-cluster-users' by name (#1359)

9c23988

Fix alias finding if user is not logged in (#1360)

9a0aaa4

Support hidden files on the storage (#1362)

3915c1e

Steal config files on 'job --pass-config' (#1361)

bbbee68

First attempt

db00fc0

Converted repeated code to table()

9891896

Fixed lint

fd35b9c

First attempt

a24b73b

Converted repeated code to table()

f20d549

Fixed lint

d637db4

Added skipping of Docker-based tests when Docker client initializati…

cd64563

…on is not successful

Renamed https_url to as_docker_url and added documentation

da9d8ef

Added CHANGELOG.D entry and fixed lint

008ed50

dalazx reviewed Mar 2, 2020

View reviewed changes

asvetlov reviewed Mar 2, 2020

View reviewed changes

olegstepanov closed this Mar 2, 2020

olegstepanov deleted the long-images-list-2 branch March 2, 2020 16:57

asvetlov mentioned this pull request Mar 25, 2020

Support long form for image ls command #1334

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Replacement PR for #1349 (neuro images ls -l support) #1354

Replacement PR for #1349 (neuro images ls -l support) #1354

olegstepanov commented Feb 26, 2020

lgtm-com bot commented Feb 26, 2020

serhiy-storchaka left a comment

codecov bot commented Feb 27, 2020 •

edited

Loading

asvetlov left a comment

dalazx left a comment

asvetlov Mar 2, 2020

olegstepanov Mar 2, 2020

asvetlov Mar 2, 2020

Replacement PR for #1349 (neuro images ls -l support) #1354

Replacement PR for #1349 (neuro images ls -l support) #1354

Conversation

olegstepanov commented Feb 26, 2020

lgtm-com bot commented Feb 26, 2020

serhiy-storchaka left a comment

Choose a reason for hiding this comment

codecov bot commented Feb 27, 2020 • edited Loading

Codecov Report

asvetlov left a comment

Choose a reason for hiding this comment

dalazx left a comment

Choose a reason for hiding this comment

asvetlov Mar 2, 2020

Choose a reason for hiding this comment

olegstepanov Mar 2, 2020

Choose a reason for hiding this comment

asvetlov Mar 2, 2020

Choose a reason for hiding this comment

codecov bot commented Feb 27, 2020 •

edited

Loading