Added support for empty input in table()

neuro-inc · Feb 26, 2020 · b91d973 · b91d973
1 parent 6c05bb5
commit b91d973
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 3 deletions.
diff --git a/neuromation/cli/formatters/ftable.py b/neuromation/cli/formatters/ftable.py
@@ -45,6 +45,8 @@ def table(
     aligns: Sequence[Align] = (),
     max_width: Optional[int] = None,
 ) -> Iterator[str]:
+    if not rows:
+        return
 
     # Columns widths calculation
     if len(widths) < len(rows[0]):

diff --git a/neuromation/cli/formatters/images.py b/neuromation/cli/formatters/images.py
@@ -150,8 +150,5 @@ def __call__(self, images: Iterable[RemoteImage]) -> Iterable[str]:
 
 class LongImagesFormatter(BaseImagesFormatter):
     def __call__(self, images: Iterable[RemoteImage]) -> Iterable[str]:
-        if not images:
-            return ()
-
         rows = [[str(image), image.https_url] for image in images]
         return table(rows)
diff --git a/tests/cli/test_ftable.py b/tests/cli/test_ftable.py
@@ -58,6 +58,10 @@ def test_multiline(self) -> None:
 
 
 class TestTable:
+    def test_empty(self) -> None:
+        result = list(table(()))
+        assert len(result) == 0
+
     def test_simple(self) -> None:
         rows = [["a", "Alpha"], ["b", "Bravo"]]
         result = list(