Skip to content

Commit

Permalink
deployer model has name restrictions, surface potential errors in dep…
Browse files Browse the repository at this point in the history
…loyer, update the tensorflow image with python3 (kubeflow#517)
  • Loading branch information
gaoning777 authored and neuromage committed Dec 13, 2018
1 parent 0697f61 commit 4c62b7e
Showing 1 changed file with 6 additions and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -49,8 +49,8 @@
"DATAFLOW_TF_PREDICT_IMAGE = 'gcr.io/ml-pipeline/ml-pipeline-dataflow-tf-predict:0.1.3-rc.2'#TODO-release: update the release tag for the next release\n",
"KUBEFLOW_TF_TRAINER_IMAGE = 'gcr.io/ml-pipeline/ml-pipeline-kubeflow-tf-trainer:0.1.3-rc.2'#TODO-release: update the release tag for the next release\n",
"KUBEFLOW_DEPLOYER_IMAGE = 'gcr.io/ml-pipeline/ml-pipeline-kubeflow-deployer:0.1.3-rc.2'#TODO-release: update the release tag for the next release\n",
"DEV_DEPLOYER_MODEL = 'notebook-tfx-devtaxi.beta'\n",
"PROD_DEPLOYER_MODEL = 'notebook-tfx-prodtaxi.beta'"
"DEV_DEPLOYER_MODEL = 'notebook_tfx_devtaxi.beta'\n",
"PROD_DEPLOYER_MODEL = 'notebook_tfx_prodtaxi.beta'"
]
},
{
Expand Down Expand Up @@ -461,8 +461,9 @@
" parent = 'projects/%s' % gcp_project\n",
" try:\n",
" api.projects().models().create(body=body, parent=parent).execute()\n",
" except:\n",
" # Trying to create an already existing model gets an error. Ignore it.\n",
" except Exception as e:\n",
" # If the error is to create an already existing model. Ignore it.\n",
" print(str(e))\n",
" pass\n",
"\n",
" import time\n",
Expand Down Expand Up @@ -565,7 +566,7 @@
" component_func=deploy_model,\n",
" staging_gcs_path=OUTPUT_DIR,\n",
" dependency=[kfp.compiler.VersionedDependency(name='google-api-python-client', version='1.7.0')],\n",
" base_image='tensorflow/tensorflow:1.12.0',\n",
" base_image='tensorflow/tensorflow:1.12.0-py3',\n",
" target_image=TARGET_IMAGE)"
]
},
Expand Down

0 comments on commit 4c62b7e

Please sign in to comment.