Adding whitespace/newline trimmers and isort
#8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I noticed `isort` was missing (you mentioned it in the [dev guidelines](https://hackmd.io/SbO3WyePSF-XEJVLZoX3og) with us. Perhaps/probably you're already on this. Also, I propose adding [`trailing-whitespace`](https://github.com/pre-commit/pre-commit-hooks#trailing-whitespace) and [`end-of-file-fixer`](https://github.com/pre-commit/pre-commit-hooks#end-of-file-fixer) from the list of pre-cooked pre-commit pre-commit hooks. Which do what you'd imagine. To quote a wise man: > "It's like having the worlds pickiest python developer watching over your shoulder."
|
Hey @samcunliffe, sorry the PR to update pre-commit hasn't been merged yet. The current state of the config is here: |
|
Oh great! You're already doing them both. |
|
[ Sorry for the noise. Shoulda checked #6. ] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed
isortwas missing (you mentioned it in the dev guidelines with us. Perhaps/probably you're already on this.Also, I propose adding
trailing-whitespaceandend-of-file-fixerfrom the list of pre-cooked pre-commit pre-commit hooks. Which do what you'd imagine.To quote a wise man: