Add warning about pinned gh-action-pypi-publish in publish-pypi #78
Conversation
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
Bumps [pypa/gh-action-pypi-publish](https://github.com/pypa/gh-action-pypi-publish) from 1.9.0 to 1.12.4. - [Release notes](https://github.com/pypa/gh-action-pypi-publish/releases) - [Commits](pypa/gh-action-pypi-publish@v1.9.0...v1.12.4) --- updated-dependencies: - dependency-name: pypa/gh-action-pypi-publish dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
|
@IgorTatarnikov I've assigned this one to you following #77 |
|
Also cc @lochhh, is this something we want/need? |
|
I'll use this PR to change the script to have our new standard (brainglobe/brainglobe-atlasapi#456) |
|
On second thought, this action should be deprecated as it is no longer be functional due to upstream changes in pypa/gh-action-pypi-publish@release/v1 |
IgorTatarnikov
changed the title
Since on gh-action-pypi-publish's readme they mentioned:
We could still keep this action, but I added a warning in the readme |
|
In that case should we pin it to the last working version, and leave it with a warning? |
yup good idea! |
IgorTatarnikov
changed the title
|
@IgorTatarnikov I'm not sure what the last working version is, as the note was only added in v1.8.12 |
|
This was based on empirical testing, when the upload action broke a couple of weeks ago we reverted to this version and it still worked. I'm comfortable pinning it to an even earlier version! |
IgorTatarnikov
deleted the
dependabot/github_actions/upload_pypi/pypa/gh-action-pypi-publish-1.12.4
branch
Bumps pypa/gh-action-pypi-publish from 1.9.0 to 1.12.4.
Release notes
Sourced from pypa/gh-action-pypi-publish's releases.
... (truncated)
Commits
76f52bcMerge pull request #329 from webknjaz/maintenance/runtime-lockfile-24-02-202572de13b📌 Mass-upgrade transitive dependency pins1995f2eMerge pull request #327 from webknjaz/maintenance/twine-6.1-pep63929f40bd📦 Enable metadata 2.4 support in Twine10df67d📦 Enable support for PEP 639 metadatae0449d2🧪 Integrate a unifiedalls-greenGHA statuscebc64f🧪 Bump setuptools in smoke test to v75.8.0da900af🧪 Run smoke tests against Ubuntu 24 and 228cafb5c💰 Sync the funding config916e576Merge pull request #315 from webknjaz/refactoring/attestations-exist-bundleDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)