[ENH] Allow HonestForest to sample higher than max_samples # of bootstraps

[adam2392]

Supersedes #204

Changes proposed in this pull request:

• build_hyppo_oob_forest and HonestForestClassifier should work together to make the predictions
• adds the S@S98 function from [Paper] Add function to calculate metrics from posteriors #192

Before submitting

• I've read and followed all steps in the Making a pull request
  section of the CONTRIBUTING docs.
• I've updated or added any relevant docstrings following the syntax described in the
  Writing docstrings section of the CONTRIBUTING docs.
• If this PR fixes a bug, I've added a test that will fail without my fix.
• If this PR adds a new feature, I've added tests that sufficiently cover my new functionality.

After submitting

• All GitHub Actions jobs for my pull request have passed.

[adam2392]

• build_hyppo_oob_forest and HonestForestClassifier should work together to make the predictions

[codecov]

Codecov Report

Attention: 61 lines in your changes are missing coverage. Please review.

Comparison is base (7fc517e) 89.13% compared to head (ac440b9) 88.29%.
Report is 2 commits behind head on main.

Files	Patch %	Lines
sktree/stats/forestht.py	6.66%	28 Missing ⚠️
sktree/ensemble/_honest_forest.py	74.15%	23 Missing ⚠️
sktree/stats/utils.py	30.00%	7 Missing ⚠️
sktree/tree/_honest_tree.py	88.46%	3 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #206      +/-   ##
==========================================
- Coverage   89.13%   88.29%   -0.84%     
==========================================
  Files          50       50              
  Lines        4492     4615     +123     
==========================================
+ Hits         4004     4075      +71     
- Misses        488      540      +52     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[PSSF23]

I don't recognize the SAS98 name, we have S@98? Also, the metric should be included in POSITIVE_METRICS and POSTERIOR_FUNCTIONS

[YuxinB]

So this is not in pip now right? Would you mind letting us know once it can be install with pip?

[adam2392]

Sure. It will be on pip once this is merged. But would prefer everyone's okay before doing so as releasing on pip takes a while of my time.

[adam2392]

I'm going to merge this in for now for the sake of getting it onto pypi, but I cannot guarantee no mistakes and would highly suggest reviewing the code before running any exps.