Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH Add SynF to Gaussian Simulation experiments #42

Merged
merged 7 commits into from
Feb 28, 2022
Merged

ENH Add SynF to Gaussian Simulation experiments #42

merged 7 commits into from
Feb 28, 2022

Conversation

nhahn7
Copy link
Contributor

@nhahn7 nhahn7 commented Dec 21, 2021 •
edited
Loading

Part of #36
Minor changes to experiment code for Gaussian simulation experiments

  • updated code to correct task_id during predictions
  • imports generate_gaussian_parity() from proglearn
  • updated RXOR and XNOR plotting functions

Edit 2/27/22

@netlify
Copy link

netlify bot commented Dec 21, 2021 •
edited
Loading

✔️ Deploy Preview for sdtf ready!

🔨 Explore the source changes: 8ce5b58

🔍 Inspect the deploy log: https://app.netlify.com/sites/sdtf/deploys/621c1c40bec4e90007d83c4e

😎 Browse the preview: https://deploy-preview-42--sdtf.netlify.app/xor_experiments

PSSF23
PSSF23 requested changes Dec 22, 2021
View reviewed changes
Copy link
Member

@PSSF23 PSSF23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the result files until the constant error issue is resolved.

@PSSF23 PSSF23 added the draft label Jan 25, 2022
@nhahn7 nhahn7 changed the title ENH Prepare SynF for Gaussian Simulation experiments (updated code) ENH Add SynF to Gaussian Simulation experiments Feb 28, 2022
@nhahn7 nhahn7 requested a review from PSSF23 February 28, 2022 01:02
PSSF23
PSSF23 approved these changes Feb 28, 2022
View reviewed changes
Copy link
Member

@PSSF23 PSSF23 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Remember to add the update_task function to ProgLearn. Some classifiers might be unnecessary in such comparisons, but we can deal with them in the future.

@PSSF23 PSSF23 merged commit d9ff23b into neurodata:main Feb 28, 2022
@nhahn7 nhahn7 deleted the ODIF branch February 28, 2022 01:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PSSF23 PSSF23 PSSF23 approved these changes

Assignees
No one assigned
Labels
draft
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nhahn7 @PSSF23