-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PureScript and Haskell conflict #1
Comments
I suspect this is what causing issues for multiple projects attempting to use this grammar: - neurocyte/zat#1 - zed-industries/zed#7543 (comment) Don't know why it wasn't static in the first place (in the original Haskell grammar), but I looked at what other grammars do and none export any functions other than those used by Tree-sitter.
I suspect this is what causing issues for multiple projects attempting to use this grammar: - neurocyte/zat#1 - zed-industries/zed#7543 (comment) Don't know why it wasn't static in the first place (in the original Haskell grammar), but I looked at what other grammars do and none export any functions other than those used by Tree-sitter.
I think I fixed it in postsolar/tree-sitter-purescript@08cdbb8, it now works for me (I tested it by updating https://github.com/neurocyte/tree-sitter on my fork and building with this updated dependency). So I believe if you update tree-sitter and its dep here it should work. I'll issue a follow-up PR to enable PureScript. |
Good to know that the purescript/haskell conflict is resolved. I will merge your PR after updating. Note that both haskell and purescript parsers apparently have sanitizer bugs so I will also disable the sanitizer in tree-sitter first. (zig enables it by default unlike clang) |
The title refers to this:
zat/src/file_types.zig
Lines 214 to 219 in 10de00d
Hi 👋, I'm the maintainer of PureScript TS grammar. It started as a fork of Haskell's grammar and its C scanner was mostly left untouched (due to me not knowing C).
Indeed if I uncomment this filetype and try to build
zat
I'm getting:I would be very grateful if you could brief me on what is the issue and/or direct me towards what I could do on my end to resolve this incompatibility.I think I fixed itThe text was updated successfully, but these errors were encountered: