Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert yarl #382

Merged
merged 1 commit into from
Apr 24, 2023
Merged

Revert yarl #382

merged 1 commit into from
Apr 24, 2023

Conversation

dalazx
Copy link
Contributor

@dalazx dalazx commented Apr 24, 2023

aio-libs/yarl#854 (comment)

This breaks essentially everything.

@codecov
Copy link

codecov bot commented Apr 24, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.05 ⚠️

Comparison is base (b05df68) 80.74% compared to head (40f47d4) 80.69%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #382      +/-   ##
==========================================
- Coverage   80.74%   80.69%   -0.05%     
==========================================
  Files          12       12              
  Lines        2202     2202              
  Branches      221      221              
==========================================
- Hits         1778     1777       -1     
  Misses        375      375              
- Partials       49       50       +1     
Flag Coverage Δ
integration 80.69% <ø> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dalazx dalazx merged commit b5321e8 into master Apr 24, 2023
@dalazx dalazx deleted the dalazx/revert-yarl branch April 24, 2023 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant