Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add log compaction implementation #849

Merged
merged 7 commits into from
Nov 15, 2023
Merged

add log compaction implementation #849

merged 7 commits into from
Nov 15, 2023

Conversation

zubenkoivan
Copy link
Contributor

@zubenkoivan zubenkoivan commented Nov 12, 2023

Log compaction implementation. Deployment will be handled in the next pr.

Copy link

codecov bot commented Nov 12, 2023

Codecov Report

Merging #849 (7c51087) into master (473f39b) will increase coverage by 1.48%.
The diff coverage is 92.62%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #849      +/-   ##
==========================================
+ Coverage   86.09%   87.58%   +1.48%     
==========================================
  Files          12       12              
  Lines        2143     2480     +337     
  Branches      296      337      +41     
==========================================
+ Hits         1845     2172     +327     
+ Misses        185      183       -2     
- Partials      113      125      +12     
Flag Coverage Δ
integration 82.41% <92.39%> (+2.57%) ⬆️
unit 44.39% <33.64%> (-3.72%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
platform_monitoring/api.py 81.74% <100.00%> (-0.04%) ⬇️
platform_monitoring/base.py 86.84% <50.00%> (-0.97%) ⬇️
platform_monitoring/logs.py 90.71% <92.92%> (+4.63%) ⬆️

@zubenkoivan zubenkoivan marked this pull request as ready for review November 12, 2023 16:02
Copy link
Contributor

@dalazx dalazx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

curious how this is gonna be integrated.

@zubenkoivan
Copy link
Contributor Author

There will be a separate pod which will invoke compact_all periodically, e.g. once in 5 mins.

@zubenkoivan zubenkoivan merged commit 1c55207 into master Nov 15, 2023
10 checks passed
@zubenkoivan zubenkoivan deleted the iz/job-logs-compact branch November 15, 2023 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants