More lenient error message check in test_save_push_failure #729
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #729 +/- ##
==========================================
+ Coverage 85.67% 85.76% +0.09%
==========================================
Files 12 12
Lines 2080 2080
Branches 318 318
==========================================
+ Hits 1782 1784 +2
+ Misses 189 188 -1
+ Partials 109 108 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reasons, the error message in
tests/integration/test_jobs_service.py::TestJobsService::test_save_push_failureon my computer is now'Get "https://unknown:5000/v2/": dial tcp: lookup unknown: Temporary failure in name resolution'instead of expected'Get https://unknown:5000/v2/: dial tcp: lookup unknown'(added double quotes around a URL). This PR makes the test passing in both cases, with and without quotes.