ENG-504 update cluster, node pool patch methods #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
zubenkoivan
commented
Dec 11, 2024
•
zubenkoivan
commented
- removed node_pool.id, now we will select node pool template by machine_type field
- removed all storage options, we will pass storage parameters directly during cluster creation and not use storage templates anymore
- updated patch_cluster method, allow part of orchestrator config to be passed
- support patch node pool size and resources
zubenkoivan
changed the title
parikls
reviewed
Dec 11, 2024
| nvidia_gpu=payload.get("nvidia_gpu") or payload.get("gpu"), | ||
| nvidia_gpu_model=( | ||
| payload.get("nvidia_gpu_model") or payload.get("gpu_model") | ||
| ), |
There was a problem hiding this comment.
@zubenkoivan Can you confirm please, we shouldn't include AMD and intel here because cloud providers doesn't have them, right?
parikls
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.