support optional cloud provider options node pools and storages

neuro-inc · Jul 14, 2022 · 12a8455 · 12a8455
1 parent 91aa11e
commit 12a8455
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 2 deletions.
diff --git a/neuro_config_client/factories.py b/neuro_config_client/factories.py
@@ -77,8 +77,12 @@ def create_cloud_provider_options(
     ) -> CloudProviderOptions:
         return CloudProviderOptions(
             type=type,
-            node_pools=[cls.create_node_pool_options(p) for p in payload["node_pools"]],
-            storages=[cls.create_storage_options(type, p) for p in payload["storages"]],
+            node_pools=[
+                cls.create_node_pool_options(p) for p in payload.get("node_pools", ())
+            ],
+            storages=[
+                cls.create_storage_options(type, p) for p in payload.get("storages", ())
+            ],
         )
 
     @staticmethod

diff --git a/tests/test_factories.py b/tests/test_factories.py
@@ -1222,6 +1222,14 @@ def test_aws_cloud_provider_options(
             ],
         )
 
+    def test_aws_cloud_provider_options_defaults(self, factory: EntityFactory) -> None:
+        response = {}
+        result = factory.create_cloud_provider_options(CloudProviderType.AWS, response)
+
+        assert result == CloudProviderOptions(
+            type=CloudProviderType.AWS, node_pools=[], storages=[]
+        )
+
     def test_google_cloud_provider_options(
         self,
         factory: EntityFactory,