Fix mounts for --volume=HOME
#977
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atemate
commented
Aug 22, 2019
| @@ -1284,8 +1284,8 @@ neuro run [OPTIONS] IMAGE [CMD]... | |||
|
|
|||
| # Starts a container pytorch:latest on a machine with smaller GPU resources | |||
| # (see exact values in `neuro config show`) and with two volumes mounted: | |||
| # storage://~ --> /var/storage/home (in read-write mode), | |||
| # storage://neuromation --> /var/storage/neuromation (in read-only mode). | |||
| # storage://<home-directory> --> /var/storage/home (in read-write mode), | |||
There was a problem hiding this comment.
side change aiming improvement of the readability
asvetlov
approved these changes
Aug 22, 2019
|
LGTM when green. |
Codecov Report
@@ Coverage Diff @@
## master #977 +/- ##
=========================================
+ Coverage 87.69% 92.29% +4.6%
=========================================
Files 37 37
Lines 4259 4259
Branches 640 640
=========================================
+ Hits 3735 3931 +196
+ Misses 409 221 -188
+ Partials 115 107 -8
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #977 +/- ##
=========================================
+ Coverage 87.69% 92.29% +4.6%
=========================================
Files 37 37
Lines 4259 4259
Branches 640 640
=========================================
+ Hits 3735 3931 +196
+ Misses 409 221 -188
+ Partials 115 107 -8
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #975