Allow neuro port-forward to accept multiple local-remote port pairs #695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anayden
changed the title
atemate
reviewed
Apr 8, 2019
atemate
reviewed
Apr 8, 2019
atemate
reviewed
Apr 8, 2019
| "", | ||
| ], | ||
| ) | ||
| def test_local_remote_port_param_type_invalid(arg) -> None: |
There was a problem hiding this comment.
still, I prefer parametrized tests as they are more clear and concise :)
There was a problem hiding this comment.
Happy debugging!
Size of a test suite is never a priority :)
atemate
reviewed
Apr 8, 2019
atemate
reviewed
Apr 8, 2019
|
please merge the current master into PR branch |
anayden
force-pushed
the
an/multiple-port-forward
branch
from
9964842 to
86a5371
Compare
Codecov Report
@@ Coverage Diff @@
## master #695 +/- ##
==========================================
+ Coverage 90.58% 91.54% +0.95%
==========================================
Files 39 40 +1
Lines 3103 3263 +160
Branches 435 450 +15
==========================================
+ Hits 2811 2987 +176
+ Misses 218 207 -11
+ Partials 74 69 -5
Continue to review full report at Codecov.
|
anayden
force-pushed
the
an/multiple-port-forward
branch
from
b26c755 to
a854cdd
Compare
anayden
changed the title
asvetlov
approved these changes
Apr 10, 2019
anayden
force-pushed
the
an/multiple-port-forward
branch
from
a854cdd to
19d31a4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #632