Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support projects in blob commands #2970

Merged
merged 3 commits into from
May 9, 2023
Merged

support projects in blob commands #2970

merged 3 commits into from
May 9, 2023

Conversation

zubenkoivan
Copy link
Contributor

closes #2954

@zubenkoivan zubenkoivan marked this pull request as draft May 5, 2023 07:41
@zubenkoivan zubenkoivan force-pushed the iz/support-project-in-blob-commands branch from 42984d9 to 1c66409 Compare May 8, 2023 07:36
@zubenkoivan zubenkoivan marked this pull request as ready for review May 8, 2023 08:03
dalazx
dalazx approved these changes May 8, 2023
View reviewed changes
Copy link
Contributor

@dalazx dalazx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one minor comment. lgtm.

@codecov
Copy link

codecov bot commented May 8, 2023 •
edited
Loading

Codecov Report

Patch coverage: 69.56% and project coverage change: +0.11 🎉

Comparison is base (9b1d01c) 73.58% compared to head (e2c6120) 73.70%.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #2970      +/-   ##
==========================================
+ Coverage   73.58%   73.70%   +0.11%     
==========================================
  Files          70       70              
  Lines       12539    12586      +47     
  Branches     2308     2314       +6     
==========================================
+ Hits         9227     9276      +49     
+ Misses       2994     2988       -6     
- Partials      318      322       +4
Impacted Files Coverage Δ
neuro-cli/src/neuro_cli/utils.py 80.44% <ø> (ø)
neuro-sdk/src/neuro_sdk/_bucket_base.py 63.35% <50.00%> (+0.22%) ⬆️
neuro-cli/src/neuro_cli/blob_storage.py 38.57% <55.00%> (+1.01%) ⬆️
neuro-sdk/src/neuro_sdk/_buckets.py 54.49% <64.70%> (-0.10%) ⬇️
neuro-cli/src/neuro_cli/click_types.py 75.84% <82.14%> (+2.75%) ⬆️
neuro-cli/src/neuro_cli/formatters/buckets.py 91.04% <100.00%> (+0.27%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

YevheniiSemendiak
YevheniiSemendiak approved these changes May 8, 2023
View reviewed changes
Copy link
Contributor

@YevheniiSemendiak YevheniiSemendiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! Thank you 💪

neuro-cli/src/neuro_cli/blob_storage.py Show resolved Hide resolved
@YevheniiSemendiak YevheniiSemendiak mentioned this pull request May 8, 2023
Closed
@zubenkoivan zubenkoivan merged commit 14f34d0 into master May 9, 2023
@zubenkoivan zubenkoivan deleted the iz/support-project-in-blob-commands branch May 9, 2023 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YevheniiSemendiak YevheniiSemendiak YevheniiSemendiak approved these changes

@dalazx dalazx dalazx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support project in platform buckets
3 participants
@zubenkoivan @dalazx @YevheniiSemendiak