Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-attach to restarted jobs #2809

Merged
merged 3 commits into from
Aug 5, 2022
Merged

Re-attach to restarted jobs #2809

merged 3 commits into from
Aug 5, 2022

Conversation

serhiy-storchaka
Copy link
Contributor

Previously "neuro run" and "neuro attach" waited until the job finished
if it restarted.

Closes #2802.

Previously "neuro run" and "neuro attach" waited until the job finished
if it restarted.
@codecov
Copy link

codecov bot commented Aug 5, 2022

Codecov Report

Merging #2809 (90272ec) into master (5f00ecc) will increase coverage by 0.12%.
The diff coverage is 58.10%.

@@            Coverage Diff             @@
##           master    #2809      +/-   ##
==========================================
+ Coverage   84.82%   84.95%   +0.12%     
==========================================
  Files          72       72              
  Lines       12491    12494       +3     
  Branches     2142     2145       +3     
==========================================
+ Hits        10596    10614      +18     
+ Misses       1478     1460      -18     
- Partials      417      420       +3     
Impacted Files Coverage Δ
neuro-cli/src/neuro_cli/ael.py 51.74% <48.21%> (+3.09%) ⬆️
neuro-cli/src/neuro_cli/formatters/jobs.py 85.48% <88.88%> (+<0.01%) ⬆️
neuro-sdk/src/neuro_sdk/_disks.py 95.40% <0.00%> (-2.30%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@serhiy-storchaka serhiy-storchaka merged commit 2465c10 into master Aug 5, 2022
@serhiy-storchaka serhiy-storchaka deleted the ss/attach-restart branch August 5, 2022 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve support of restarted jobs
1 participant