Add neuro admin add-quota / set-quota commands #1275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asvetlov
approved these changes
Jan 2, 2020
anayden
changed the title
asvetlov
reviewed
Jan 14, 2020
asvetlov
reviewed
Jan 14, 2020
| if value is None: | ||
| return None | ||
| try: | ||
| result = float(value[:-1]) * {"h": 60, "m": 1}[value[-1]] |
There was a problem hiding this comment.
Please improve the error reporting; _parse_quota_value("5z") generates obscure KeyError: 'z' exception.
| cluster_name = root.client.config.cluster_name | ||
| click.echo( | ||
| f"In order to increase your quota, please navigate to " | ||
| f"https://neuro.payments.com/{user_name}/{cluster_name}?pay=usd100" |
There was a problem hiding this comment.
Should this URL be a part of a server provided config?
There was a problem hiding this comment.
Eventually, yes. But this particular part is not finished yet (and the command is disabled). It will be completely released after Evil Martians complete their part and it's tracked via a separate issue.
Co-Authored-By: Andrew Svetlov <[email protected]>
Co-Authored-By: Andrew Svetlov <[email protected]>
Co-Authored-By: Andrew Svetlov <[email protected]>
Co-Authored-By: Andrew Svetlov <[email protected]>
asvetlov
approved these changes
Jan 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1255
Until https://github.com/neuromation/platform-admin/pull/92 is merged and deployed, we can't have e2e tests, so only stubbed ones for now.