Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow to list images without docker cli installed #1186

Merged
merged 5 commits into from
Nov 22, 2019
Merged

Allow to list images without docker cli installed #1186

merged 5 commits into from
Nov 22, 2019

Conversation

shagren
Copy link
Contributor

@shagren shagren commented Nov 21, 2019

closes #1071

@shagren shagren requested a review from asvetlov November 21, 2019 12:59
@shagren shagren self-assigned this Nov 21, 2019
asvetlov
asvetlov reviewed Nov 21, 2019
View reviewed changes
neuromation/api/images.py Outdated Show resolved Hide resolved
asvetlov
asvetlov requested changes Nov 21, 2019
View reviewed changes
Copy link
Contributor

@asvetlov asvetlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changelog please

@lgtm-com
Copy link

lgtm-com bot commented Nov 21, 2019

This pull request fixes 5 alerts when merging 9eb9e16 into 730f8f2 - view on LGTM.com

fixed alerts:

  • 3 for Conflicting attributes in base classes
  • 2 for Module is imported with 'import' and 'import from'

Ilya Gruzinov and others added 2 commits November 21, 2019 16:12
@shagren shagren requested a review from asvetlov November 21, 2019 13:15
asvetlov
asvetlov reviewed Nov 21, 2019
View reviewed changes
CHANGELOG.D/1071.feature Outdated Show resolved Hide resolved
@asvetlov
Copy link
Contributor

Please merge after fixing the linter.

Ilya Gruzinov and others added 2 commits November 21, 2019 16:19
@shagren shagren merged commit 01af5ca into master Nov 22, 2019
@shagren shagren deleted the shagren/allow-images-ls-without-docker branch November 22, 2019 08:24
@shagren shagren mentioned this pull request Dec 4, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asvetlov asvetlov asvetlov approved these changes

Assignees

@shagren shagren

Labels
CLIents platform
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

neuro image ls requires Docker on a user machine
3 participants
@shagren @asvetlov @astaff