Update Developing Markdown #1617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsikka
previously approved these changes
Jun 9, 2023
bfineran
reviewed
Jun 9, 2023
DEVELOPING.md
Outdated
| @@ -40,6 +40,9 @@ Those can be installed by adding the framework name to the install extras. Frame | |||
| python3 -m pip install -e "./[dev,torch]" | |||
| ``` | |||
|
|
|||
| Note: Running all pytorch tests using `make test TARGETS=torch`, also requires `torchvision` | |||
| and `onnxruntime` install all these dependencies using `python3 -m pip install "./[dev, torch, torchvision, onnxruntime]"` | |||
mgoin
approved these changes
Jun 9, 2023
dsikka
approved these changes
Jun 9, 2023
bfineran
approved these changes
Jun 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add note for running torch tests