Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[YOLOv8] Fix support for --dataset_dir argument #1520

Merged
merged 8 commits into from
Apr 20, 2023
Merged

[YOLOv8] Fix support for --dataset_dir argument #1520

merged 8 commits into from
Apr 20, 2023

Conversation

dbogunowicz
Copy link
Contributor

@dbogunowicz dbogunowicz commented Apr 13, 2023 •
edited
Loading

This PR: #1513 was not tested rigorously and was failing for all the pathways. This PR fixes this.

Testing:

  • tested validation pathway
  • tested export pathway (generating samples and using the data for calculating gradients at one-shot)
  • tested training pathway

@dbogunowicz dbogunowicz force-pushed the feature/damian/support_dataset_dir branch from 916d265 to 2149bb2 Compare April 13, 2023 15:15
@dbogunowicz dbogunowicz marked this pull request as ready for review April 13, 2023 15:18
@dbogunowicz dbogunowicz changed the title [YOLOv8] Fix support for dataset_dir [YOLOv8] Fix support for --dataset_dir argument Apr 13, 2023
@dbogunowicz dbogunowicz mentioned this pull request Apr 13, 2023
Merged
anmarques
anmarques requested changes Apr 13, 2023
View reviewed changes
Copy link
Member

@anmarques anmarques left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I just recommend replacing --datasets-dir by --dataset-path where the later refers to the complete path to the dataset rather than it's parent directory

bfineran
bfineran previously approved these changes Apr 13, 2023
View reviewed changes
@bfineran
Copy link
Contributor

LGTM pending comment

@dbogunowicz dbogunowicz force-pushed the feature/damian/support_dataset_dir branch from 9f2dc82 to 752ed10 Compare April 14, 2023 12:12
anmarques
anmarques requested changes Apr 14, 2023
View reviewed changes
@dbogunowicz dbogunowicz merged commit e302ec4 into main Apr 20, 2023
@dbogunowicz dbogunowicz deleted the feature/damian/support_dataset_dir branch April 20, 2023 10:55
anmarques pushed a commit that referenced this pull request Apr 26, 2023
@dbogunowicz @anmarques
[YOLOv8] Fix support for --dataset_dir argument (#1520)
b03cd91 
* working

* working

* addressing comments from review

* add more verbose error message

* Apply suggestions from code review

* Update helpers.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anmarques anmarques anmarques approved these changes

@rahul-tuli rahul-tuli rahul-tuli approved these changes

@bfineran bfineran Awaiting requested review from bfineran

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dbogunowicz @bfineran @anmarques @rahul-tuli