This repository has been archived by the owner on Oct 11, 2024. It is now read-only.
Benchmark Fix : Remove special tokens from warmup prompts #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
varun-sundar-rabindranath
requested review from
tlrmchlsmth,
mgoin,
bnellnm and
robertgshaw2-redhat
robertgshaw2-redhat
approved these changes
Mar 20, 2024
mgoin
approved these changes
Mar 20, 2024
varun-sundar-rabindranath
deleted the
varun/fix-sporadic-benchmark-failure
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
When sampling words at random for prompt generation, we sometimes pick up the
<pad>token.The Tokenizer doesn't recognize this as a special token and leaves it in the prompt as-is. This causes the backend to fail with,
like errors.
Test:
Manual tests