Skip to content
This repository has been archived by the owner on Oct 11, 2024. It is now read-only.

whl centric workflow for "remote push" #117

Merged
merged 29 commits into from
Apr 1, 2024
Merged

whl centric workflow for "remote push" #117

merged 29 commits into from
Apr 1, 2024

Conversation

andy-neuma
Copy link
Member

@andy-neuma andy-neuma commented Mar 13, 2024

SUMMARY:

  • moves "nm-vllm" to whl centric workflows. this means that testing is conducted on a fresh instance via installing "nm-vllm" whl into a venv.
  • update build action to also generate whl and source distributions.
  • update testing action to work via whl install.
  • updates callable build workflow to build, generate whl, and source distribution. artifacts are uploaded to GHA artifact store.
  • updates callable test workflow to install whl and run tests.
  • patch code coverage to work with "forked" processes

NOTES: currently we are building on a GPU instance, but technically this isn't a requirement. the current non-gpu instance we have in our runner group doesn't have enough memory. this results on builds sporadically failing, so "remote push" is set up to run on T4's.

TEST PLAN:
runs on remote push

@andy-neuma andy-neuma changed the title Whl centric whl centric workflow for "remote push" Mar 13, 2024
@dhuangnm
Copy link
Member

The tarball generation is covered in my PR: #138

Maybe we can merge the two or separate the tarball part out in its own PR.

@andy-neuma
Copy link
Member Author

@dhuangnm - as of this diff, we will always be building whl and source distributions.

@varun-sundar-rabindranath

LGTM !

@andy-neuma andy-neuma merged commit ff768a8 into main Apr 1, 2024
2 checks passed
@andy-neuma andy-neuma deleted the whl-centric branch April 1, 2024 17:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants