This repository has been archived by the owner on Oct 11, 2024. It is now read-only.
forked from vllm-project/vllm
-
Notifications
You must be signed in to change notification settings - Fork 11
whl centric workflow for "remote push" #117
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The tarball generation is covered in my PR: #138 Maybe we can merge the two or separate the tarball part out in its own PR. |
@dhuangnm - as of this diff, we will always be building whl and source distributions. |
LGTM ! |
varun-sundar-rabindranath
approved these changes
Apr 1, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY:
NOTES: currently we are building on a GPU instance, but technically this isn't a requirement. the current non-gpu instance we have in our runner group doesn't have enough memory. this results on builds sporadically failing, so "remote push" is set up to run on T4's.
TEST PLAN:
runs on remote push