Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finalize First Iteration of the Testing Suite #4

Merged
merged 15 commits into from
Dec 12, 2023

Conversation

garrettmflynn
Copy link
Member

@garrettmflynn garrettmflynn commented Dec 11, 2023

This PR completes the first iteration of a testing suite for commoners (#2).

Notably, this doesn't test the following conditions yet:

  1. Electron Build — When run through vitest, electron-builder is blocked and breaks because of an stdio error—although a manual build works.
  2. Electron Start — electron-vite was not accepting different roots, so a secondary testing command (test:electron) was created to temporarily bypass this limitation. However, it was found that we cannot request the debugURL from Puppeteer because of a CORS error, so there is no ability to control that window (i.e. run E2E tests) or quit the app when complete.
  3. Mobile — Both mobile build and start have not been approached in this PR because of less usage and the lack of a good E2E testing strategy.

Based on the new testing workflow and setting in GitHub, all PRs merging to main must now pass this suite.

@garrettmflynn garrettmflynn self-assigned this Dec 11, 2023
@garrettmflynn garrettmflynn merged commit a073656 into main Dec 12, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant