Finalize First Iteration of the Testing Suite #4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR completes the first iteration of a testing suite for
commoners
(#2).Notably, this doesn't test the following conditions yet:
electron-builder
is blocked and breaks because of an stdio error—although a manual build works.electron-vite
was not accepting different roots, so a secondary testing command (test:electron
) was created to temporarily bypass this limitation. However, it was found that we cannot request the debugURL from Puppeteer because of a CORS error, so there is no ability to control that window (i.e. run E2E tests) or quit the app when complete.Based on the new testing workflow and setting in GitHub, all PRs merging to
main
must now pass this suite.