Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(api): add GraphQL code generation #130

Merged
merged 6 commits into from
Dec 2, 2024
Merged

feat(api): add GraphQL code generation #130

merged 6 commits into from
Dec 2, 2024

Conversation

Robert27
Copy link
Member

@Robert27 Robert27 commented Dec 2, 2024

No description provided.

@Robert27 Robert27 requested a review from Copilot December 2, 2024 13:05
@Robert27 Robert27 changed the title feat(gql): add GraphQL code generation feat(api): add GraphQL code generation Dec 2, 2024
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 10 out of 25 changed files in this pull request and generated 2 suggestions.

Files not reviewed (15)
  • ios/NeulandNext.xcodeproj/project.pbxproj: Language not supported
  • package.json: Language not supported
  • src/generated/gql/fragment-masking.ts: Language not supported
  • src/generated/gql/gql.ts: Language not supported
  • src/generated/gql/index.ts: Language not supported
  • src/data/licenses.json: Language not supported
  • src/components/Rows/EventRow.tsx: Evaluated as low risk
  • src/contexts/preferences.ts: Evaluated as low risk
  • src/api/neuland-api.ts: Evaluated as low risk
  • src/app/(flow)/onboarding.tsx: Evaluated as low risk
  • src/components/Rows/SportsRow.tsx: Evaluated as low risk
  • src/components/Cards/PopUpCard.tsx: Evaluated as low risk
  • src/components/Events/ClEventsPage.tsx: Evaluated as low risk
  • src/components/Events/ClSportsPage.tsx: Evaluated as low risk
  • src/components/Map/MapScreen.tsx: Evaluated as low risk
Comments skipped due to low confidence (2)

src/app/(tabs)/(index)/index.tsx:71

  • The query key 'announcenments' is misspelled. It should be 'announcements'.
queryKey: ['announcenments'],

src/app/(screens)/clEvent.tsx:43

  • Ensure that startDateTime and endDateTime are not null before calling formatFriendlyDateTimeRange to prevent potential errors.
const dateRange = formatFriendlyDateTimeRange(clEvent?.startDateTime != null ? new Date(clEvent.startDateTime) : null, clEvent?.endDateTime != null ? new Date(clEvent.endDateTime) : null)

src/api/gql-documents.ts Outdated Show resolved Hide resolved
src/app/(tabs)/(index)/index.tsx Outdated Show resolved Hide resolved
@Robert27 Robert27 requested a review from Copilot December 2, 2024 13:11

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 11 out of 26 changed files in this pull request and generated no suggestions.

Files not reviewed (15)
  • ios/NeulandNext.xcodeproj/project.pbxproj: Language not supported
  • package.json: Language not supported
  • src/generated/gql/fragment-masking.ts: Language not supported
  • src/generated/gql/gql.ts: Language not supported
  • src/generated/gql/index.ts: Language not supported
  • src/data/licenses.json: Language not supported
  • src/contexts/preferences.ts: Evaluated as low risk
  • src/components/Rows/SportsRow.tsx: Evaluated as low risk
  • src/components/Events/ClSportsPage.tsx: Evaluated as low risk
  • src/components/Cards/PopUpCard.tsx: Evaluated as low risk
  • src/components/Events/ClEventsPage.tsx: Evaluated as low risk
  • src/components/Map/MapScreen.tsx: Evaluated as low risk
  • src/app/(flow)/onboarding.tsx: Evaluated as low risk
  • src/app/(tabs)/(index)/index.tsx: Evaluated as low risk
  • src/app/(screens)/sportsEvent.tsx: Evaluated as low risk
Comments skipped due to low confidence (2)

src/components/Rows/EventRow.tsx:40

  • Ensure that the fallback behavior for the title field (i.e., using an empty string if the value is null or undefined) is covered by tests.
title={event.titles[i18n.language as LanguageKey] ?? ''}

src/api/neuland-api.ts:56

  • Typo in JSDoc comment: 'announcement ndata' should be 'announcement data'.
* Get the announcement ndata from the GraphQL API
@Robert27 Robert27 marked this pull request as ready for review December 2, 2024 13:14
@Robert27 Robert27 merged commit e824635 into main Dec 2, 2024
4 checks passed
@Robert27 Robert27 deleted the feat/codegen branch December 2, 2024 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant