Skip to content
This repository has been archived by the owner on Feb 16, 2024. It is now read-only.

Added an overload to the Sample operator to take another observable t… #176

Merged
merged 2 commits into from
Sep 29, 2016

Conversation

svermeulen
Copy link
Contributor

…o use to determine the sample interval. This is just a more generic version of SampleFrame. To minimize duplication I also changed SampleFrame to be implemented based on this more generic version.

…o use to determine the sample interval. This is just a more generic version of SampleFrame. To minimize duplication I also changed SampleFrame to be implemented based on this more generic version.
@neuecc
Copy link
Owner

neuecc commented Sep 24, 2016

In performance reason, Sample will be replaced optimized code #165
so should not replace SampleFrameObservable to SampleObservableObseravble.

This is missing operator of Rx.NET Sample<T, TSample>(IObservable<T> source, IObservable<TSample> sampler). #105
Yes, this is necessary method, thank you!
But it should locate in Operators/Sample https://github.com/neuecc/UniRx/blob/master/Assets/Plugins/UniRx/Scripts/Operators/Sample.cs

@svermeulen
Copy link
Contributor Author

Ok I'll submit it again with those changes.

…med SapmleObservable.cs to Sample.cs and fixed the csproj
@svermeulen
Copy link
Contributor Author

Did I understand those changes correctly?

@neuecc
Copy link
Owner

neuecc commented Sep 25, 2016

Thank you!
almost okay.
I'll merge and fix after it.

@neuecc neuecc merged commit 5851d61 into neuecc:master Sep 29, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants