Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New template for huawei VRP + fix. #998

Merged
merged 1 commit into from
Oct 15, 2021
Merged

Conversation

ak-empiak
Copy link
Contributor

new templates for huawei_vrp + 1 fixed.

ISSUE TYPE
  • New Template Pull Request (+ little fix of existing huawei template)
COMPONENT

new: huawei_vrp - display interface description
new: huawei_vrp - display port vlan
fixed: huawei_vrp - display interface brief

SUMMARY
  1. new: huawei_vrp - display interface description
    simple list of interfaces with their unique physical/protocol states and description.
    can match empty DESCRIPTION
  2. new: huawei_vrp - display port vlan
    list of interfaces with unique link type and pvid, and a list of all vlans on trunk interface
    match empty TRUNK_VLAN_LIST for access link for example.
  3. fixed: huawei_vrp - display interface brief
    the state '#down: LBDT down' was not matched and returned an error if present in switch.

@ak-empiak
Copy link
Contributor Author

The CI error is :
Error on line: ['huawei_vrp_display_interface_description.textfsm', ' .*', ' huawei_vrp', ' disp[[lay]] inter[[face]] des[[cription]]']
Error Message: Current Command len '37' larger then previous '31', for command 'display_interface_description.textfsm'

I don't understand what it means, I will try to troubleshoot it as soon as possible, but if anyone could give me any indication, I would be glad :)

@itdependsnetworks
Copy link
Contributor

Look at the question “ Why does the index order matter?” on the readme of the project

@ak-empiak
Copy link
Contributor Author

fixed, rebased (pick squash), force-pushed, check passed ^^

@ak-empiak
Copy link
Contributor Author

hello fellows,
still not merged ?

Copy link
Contributor

@jvanderaa jvanderaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jvanderaa jvanderaa merged commit 9dead70 into networktocode:master Oct 15, 2021
jvanderaa pushed a commit that referenced this pull request Nov 10, 2021
…rp dis_int_br (#998)

Add new templates `huawei_vrp` `dis_int_desc`  `dis_port_vlan`
guillaume-mbali pushed a commit to unyc-io/ntc-templates that referenced this pull request Apr 12, 2023
…rp dis_int_br (networktocode#998)

Add new templates `huawei_vrp` `dis_int_desc`  `dis_port_vlan`
cppmonkey pushed a commit to cppmonkey/ntc-templates that referenced this pull request Oct 25, 2023
…rp dis_int_br (networktocode#998)

Add new templates `huawei_vrp` `dis_int_desc`  `dis_port_vlan`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants