Bugfix: change date format in hp_comware_display_clock.textfsm #977
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As per https://techhub.hpe.com/eginfolib/networking/docs/switches/5940/5200-1008b_fund_cr/content/491962772.htm output of the `display clock` commands output contains date in `MM/DD/YYYY` format. Can confirm this on different types of HPE switches I have at my disposal. Added test cases that cover the scenarios when time zone and daylight time saving configurations are set.
antonalekseev
requested review from
FragmentedPacket,
itdependsnetworks,
jmcgill298 and
jvanderaa
as code owners
|
@FragmentedPacket / @jmcgill298 thoughts on this? I cannot confirm myself. |
jvanderaa
pushed a commit
that referenced
this pull request
Nov 10, 2021
As per https://techhub.hpe.com/eginfolib/networking/docs/switches/5940/5200-1008b_fund_cr/content/491962772.htm output of the `display clock` commands output contains date in `MM/DD/YYYY` format. Can confirm this on different types of HPE switches I have at my disposal. Added test cases that cover the scenarios when time zone and daylight time saving configurations are set.
guillaume-mbali
pushed a commit
to unyc-io/ntc-templates
that referenced
this pull request
Apr 12, 2023
…rktocode#977) As per https://techhub.hpe.com/eginfolib/networking/docs/switches/5940/5200-1008b_fund_cr/content/491962772.htm output of the `display clock` commands output contains date in `MM/DD/YYYY` format. Can confirm this on different types of HPE switches I have at my disposal. Added test cases that cover the scenarios when time zone and daylight time saving configurations are set.
cppmonkey
pushed a commit
to cppmonkey/ntc-templates
that referenced
this pull request
Oct 25, 2023
…rktocode#977) As per https://techhub.hpe.com/eginfolib/networking/docs/switches/5940/5200-1008b_fund_cr/content/491962772.htm output of the `display clock` commands output contains date in `MM/DD/YYYY` format. Can confirm this on different types of HPE switches I have at my disposal. Added test cases that cover the scenarios when time zone and daylight time saving configurations are set.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ISSUE TYPE
COMPONENT
hp_comware_display_clock.textfsmSUMMARY
As per
https://techhub.hpe.com/eginfolib/networking/docs/switches/5940/5200-1008b_fund_cr/content/491962772.htm (archived https://archive.is/nq4Yp)
output of the
display clockcommand output contains date inMM/DD/YYYYformat. Can confirm this on different types of HPE switches I have at my disposal.
Added test cases that cover the scenarios when time zone and daylight time
saving configurations are set.