Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue #929 #934

Merged
merged 1 commit into from
Jun 24, 2021
Merged

Fix issue #929 #934

merged 1 commit into from
Jun 24, 2021

Conversation

matt852
Copy link
Contributor

@matt852 matt852 commented May 26, 2021

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT

arista_eos_show_lldp_neighbors_detail.textfsm
EOS
show lldp neighbors detail

SUMMARY

This fixes the issue #929 where if the last device in the "show lldp neighbors detail" output is an LLDP neighbor, it is omitted from the parsed output.

Using the output and example script as referenced in issue #929:

Current state:

['test-host.domain.com', '0cca.01c0.e8e1', '172.16.208.5', '', 'Ethernet4', 'Ethernet4', '1', '28 seconds']

With PR fix:

['test-host.domain.com', '0cca.01c0.e8e1', '172.16.208.5', '', 'Ethernet4', 'Ethernet4', '1', '28 seconds']
['test-host.domain.com', '0cca.01c0.e8e1', '172.16.208.5', '', 'Management1', 'Management1', '1', '2 seconds']

@FragmentedPacket FragmentedPacket merged commit eef3e64 into networktocode:master Jun 24, 2021
jvanderaa pushed a commit that referenced this pull request Nov 10, 2021
@matt852
aristra_eos_show_lldp_neighbors: Make argument required to capture al…
eca841f 
…l entries (#934)
guillaume-mbali pushed a commit to unyc-io/ntc-templates that referenced this pull request Apr 12, 2023
@matt852
aristra_eos_show_lldp_neighbors: Make argument required to capture al…
fc5f445 
…l entries (networktocode#934)
cppmonkey pushed a commit to cppmonkey/ntc-templates that referenced this pull request Oct 25, 2023
@matt852 @cppmonkey
aristra_eos_show_lldp_neighbors: Make argument required to capture al…
e2957f6 
…l entries (networktocode#934)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FragmentedPacket FragmentedPacket FragmentedPacket approved these changes

@itdependsnetworks itdependsnetworks Awaiting requested review from itdependsnetworks itdependsnetworks is a code owner

@jmcgill298 jmcgill298 Awaiting requested review from jmcgill298 jmcgill298 is a code owner

@jvanderaa jvanderaa Awaiting requested review from jvanderaa jvanderaa is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matt852 @FragmentedPacket