Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added fortinet get system arp #832

Merged
merged 2 commits into from
Dec 2, 2020

Conversation

wmclendon
Copy link
Contributor

ISSUE TYPE
  • New Template Pull Request
COMPONENT
  • fortinet_get_system_arp.textfsm template for arp table for Fortinet
SUMMARY

Added template fortinet_get_system_arp to parse the ARP table output of Fortinet's Fortigate devices.
Tested against a live FGT-60D running v6.0.6.

Copy link
Contributor

@jmcgill298 jmcgill298 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @wmclendon

We do require all new templates to raise an Error for unmatched lines so we can be confident that the data is parsed accurately. I have added that as a code suggestion for you.

templates/fortinet_get_system_arp.textfsm Outdated Show resolved Hide resolved
@jmcgill298 jmcgill298 added changes_requested Waiting on user to address feedback New Template labels Dec 2, 2020
added error for unmatched lines per requirement

Co-authored-by: Jacob McGill <[email protected]>
@jmcgill298 jmcgill298 merged commit 397b495 into networktocode:master Dec 2, 2020
@jmcgill298
Copy link
Contributor

Thanks @wmclendon

jvanderaa pushed a commit that referenced this pull request Nov 10, 2021
guillaume-mbali pushed a commit to unyc-io/ntc-templates that referenced this pull request Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changes_requested Waiting on user to address feedback New Template
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants