New Template: cisco_ios_show_ip_ospf_database_router #606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmcgill298
requested changes
Mar 2, 2020
There was a problem hiding this comment.
@ChristopherJHart Each state should end with
^\s*$$
^. -> Error
This ensures that we are not missing any data and incorrectly reporting back the data. This also means that each line in the output must be accounted for with a match (non-capturing).
|
@jmcgill298 Apologies! I've modified the TextFSM template states accordingly. Thank you! |
FragmentedPacket
suggested changes
Mar 6, 2020
tests/cisco_ios/show_ip_ospf_database_router/cisco_ios_show_ip_ospf_database_router.yml
Show resolved
Hide resolved
FragmentedPacket
added
changes_requested
Fix bug with detecting hexadecimal LSA sequence numbers Co-Authored-By: Mikhail Yohman <[email protected]>
FragmentedPacket
suggested changes
Mar 8, 2020
tests/cisco_ios/show_ip_ospf_database_router/cisco_ios_show_ip_ospf_database_router.yml
Show resolved
Hide resolved
FragmentedPacket
approved these changes
Mar 8, 2020
thomasblass
pushed a commit
to thomasblass/ntc-templates
that referenced
this pull request
Oct 25, 2020
jvanderaa
pushed a commit
that referenced
this pull request
Nov 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ISSUE TYPE
COMPONENT
cisco_ios_show_ip_ospf_database_router
SUMMARY
show ip ospf database routeron Cisco IOS.Let me know if any changes are needed - thank you!