Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes for cisco_ios_show_running-config_partition_access-list template #598

Merged
merged 7 commits into from
Feb 27, 2020
Merged

Fixes for cisco_ios_show_running-config_partition_access-list template #598

merged 7 commits into from
Feb 27, 2020

Conversation

jpobeda
Copy link
Contributor

@jpobeda jpobeda commented Feb 23, 2020 •
edited
Loading

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT

cisco_ios_show_running-config_partition_access-list.textfsm
cisco_ios
show running-config | section access-list

SUMMARY
  • PROTOCOL capture group wouldn't match numbers.
  • SRC_PORT_RANGE_START capture group was incorrect.
  • TCP flags weren't captured.
  • Comment typo on "Record numerd ACL Remark"
  • COMMENT is now a List, allowing for consecutive remarks.

@jpobeda
Copy link
Contributor Author

jpobeda commented Feb 24, 2020

Hi @jmcgill298 ,

Blame github reviewers suggestions hehe

How do we get around this one? I added a missing/ignored capture group for tcp_flags. So even though it works backwards, people will get a new key/value pair on their dictionaries.

@jmcgill298 jmcgill298 merged commit b34587d into networktocode:master Feb 27, 2020
@jmcgill298
Copy link
Contributor

Thanks @jpobeda

@jpobeda jpobeda deleted the ios_partition_acl branch February 27, 2020 18:48
thomasblass pushed a commit to thomasblass/ntc-templates that referenced this pull request Oct 25, 2020
@jpobeda @thomasblass
Enhancements: IOS show run partition access-list (networktocode#598)
7185755 
* Add Capture Group `TCP_FLAG`
* Convert `COMMENT` to a List
* Update `PROTOCOL` to include numbered protocols
jvanderaa pushed a commit that referenced this pull request Nov 10, 2021
@jpobeda
Enhancements: IOS show run partition access-list (#598)
28933af 
* Add Capture Group `TCP_FLAG`
* Convert `COMMENT` to a List
* Update `PROTOCOL` to include numbered protocols
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jpobeda @jmcgill298