Adding support for avaya_ers_show_logging_config command

[kadecole]

ISSUE TYPE

• New Template Pull Request

COMPONENT

avaya_ers_show_logging_config

SUMMARY

Adding new template for Avaya ERS for show logging config command

[jmcgill298]

It seems that you are just capturing the text after :, so this can be simplified to just use (.+?) for the capture group and mark the end of the line \s*$$

New templates require raising errors for raw lines that are not parsed so we can ensure we know we have parsed the data correctly; my suggestions have also included this.

I am also not sure what Done is doing at the end of the template file; can you please inform us how that is being used?

[kadecole]

Thanks for the code review. I have updated the PR with some of the changes requested.

I based this template off previous templates and they showed Done on the last line of the file. If this Done is not needed I will remove.

Also for the other code review suggestions, I am matching on what should be returned. There should only be two options for the text returning in those fields.

[jmcgill298]

I still think it is safer to use (.+?) in case they change caps, short forms, or add options in the future, but I am okay to leave it like it is. However, I would like to remove Done since it should not be doing anything, and I think it is confusing for anyone looking at this later. Once that is done, I am good to merge.

[kadecole]

I have updated from your suggestions. Please review and merge when possible. Thanks.