New Template Alcatel AOS: show interfaces status
#1909
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evilmonkey19
requested review from
itdependsnetworks,
jmcgill298 and
jvanderaa
as code owners
mjbear
reviewed
Nov 22, 2024
ntc_templates/templates/alcatel_aos_show_interfaces_status.textfsm
Outdated
Show resolved
Hide resolved
mjbear
reviewed
Nov 22, 2024
ntc_templates/templates/alcatel_aos_show_interfaces_status.textfsm
Outdated
Show resolved
Hide resolved
mjbear
reviewed
Nov 22, 2024
ntc_templates/templates/alcatel_aos_show_interfaces_status.textfsm
Outdated
Show resolved
Hide resolved
mjbear
reviewed
Nov 22, 2024
| Value CONFIGURED_PAUSE (\S+) | ||
| Value CONFIGURED_FEC (\S+) | ||
| Value LINK_TRAP (\S+) | ||
| Value EEE (\S+) |
There was a problem hiding this comment.
Should EEE be spelled out?
It makes it more clear at the expense of a long capture group name.
Thoughts?
Configuring Energy Efficient Ethernet (802.3az)
Energy Efficient Ethernet (EEE) is a protocol to allow ports to operate in idle or low power mode when
there is no traffic to send
reference: page 59 of https://www.al-enterprise.com/-/media/assets/internet/documents/n-to-s/omniswitch-aos-release-810r1-network-configuration-user-guide-rev-a-en.pdf
mjbear
reviewed
Nov 22, 2024
tests/alcatel_aos/show_interfaces_status/alcatel_aos_show_interfaces_status_R6.yml
Outdated
Show resolved
Hide resolved
mjbear
reviewed
Nov 22, 2024
tests/alcatel_aos/show_interfaces_status/alcatel_aos_show_interfaces_status_R8.yml
Outdated
Show resolved
Hide resolved
…rfaces_status_R8.yml Co-authored-by: Michael Bear <[email protected]>
…tfsm Co-authored-by: Michael Bear <[email protected]>
…tfsm Co-authored-by: Michael Bear <[email protected]>
…tfsm Co-authored-by: Michael Bear <[email protected]>
…rfaces_status_R6.yml Co-authored-by: Michael Bear <[email protected]>
|
@mjbear and @jmcgill298 Do you any more suggestions for this pull-request? |
jmcgill298
reviewed
Dec 9, 2024
ntc_templates/templates/alcatel_aos_show_interfaces_status.textfsm
Outdated
Show resolved
Hide resolved
jmcgill298
reviewed
Dec 9, 2024
tests/alcatel_aos/show_interfaces_status/alcatel_aos_show_interfaces_status_R8.raw
Outdated
Show resolved
Hide resolved
jmcgill298
approved these changes
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.