Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix - junos show version for vmhosts #1823

Merged
merged 3 commits into from
Aug 15, 2024

Conversation

mjbear
Copy link
Contributor

@mjbear mjbear commented Aug 14, 2024

resolves #1224
bugfix

  • handle CHEF lines
  • handle Junos for Automation Enhancement lines
  • handle additional Junos package names for Juniper vmhosts

Note: without further raw test output this is possibly incomplete

@mjbear mjbear changed the title Junos sh ver issue1224 bugfix - junos show version for vmhosts Aug 14, 2024
@jmcgill298
Copy link
Contributor

@mjbear aside from additional test data, is this ready to go?

@mjbear
Copy link
Contributor Author

mjbear commented Aug 15, 2024

@mjbear aside from additional test data, is this ready to go?

Yes

I used what test data I could from what was posted in the initial issue #1224 as well as what Andy had posted over there too.

@jmcgill298
Copy link
Contributor

jmcgill298 commented Aug 15, 2024

Thanks @mjbear, I will go ahead and merge then and mark that issue resolved. We can update again later if needed

@jmcgill298 jmcgill298 marked this pull request as ready for review August 15, 2024 13:29
@jmcgill298 jmcgill298 merged commit 91af9c6 into networktocode:master Aug 15, 2024
14 checks passed
@mjbear mjbear deleted the junos_sh_ver_issue1224 branch August 16, 2024 02:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Juniper vmhost "show version" template not compatible with the output
2 participants