Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance - add error counter capture groups to cisco_xr_show_interfaces #1792

Merged
merged 2 commits into from
Jul 29, 2024

Conversation

mjbear
Copy link
Contributor

@mjbear mjbear commented Jul 28, 2024

resolves #1180
enhancement

Mimic rules and capture group names like cisco_ios_show_interfaces has for input/output rates and error counters on cisco_xr_show_interfaces. Plenty of modification required as the line patterns differed.

I started gearing up to add all unwanted line patterns (I still could 🤔), but once I added an ^. -> Error line there were plenty of errors. Seeing as how the template didn't start that way I paused that part. If the Error rule does need added there will be a plethora of line patterns that need to be added to the template. Not impossible, just a bunch of lines to add.

@mjbear mjbear changed the title add error counter capture groups to cisco_xr_show_interfaces enhance - add error counter capture groups to cisco_xr_show_interfaces Jul 29, 2024
@jmcgill298 jmcgill298 merged commit 507d57c into networktocode:master Jul 29, 2024
14 checks passed
@mjbear mjbear deleted the xr_sh_int_errors_issue1180 branch July 29, 2024 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add errors to cisco_xr_show_interfaces
2 participants