enhance - add error counter capture groups to cisco_xr_show_interfaces #1792
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #1180
enhancement
Mimic rules and capture group names like
cisco_ios_show_interfaces
has for input/output rates and error counters oncisco_xr_show_interfaces
. Plenty of modification required as the line patterns differed.I started gearing up to add all unwanted line patterns (I still could 🤔), but once I added an
^. -> Error
line there were plenty of errors. Seeing as how the template didn't start that way I paused that part. If theError
rule does need added there will be a plethora of line patterns that need to be added to the template. Not impossible, just a bunch of lines to add.