bugfix - handle fortinet unhealthy HA status in fortinet_get_system_ha_status #1791
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
get_system_ha_status
mjbear
requested review from
itdependsnetworks,
jmcgill298 and
jvanderaa
as code owners
mjbear
changed the title
jmcgill298
approved these changes
Jul 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #1690
bugfix
In FortiOS 7.0 (but possibly other versions), when there is an unhealthy HA status the warning is not on the same line as "HA Health Status:". Instead the status/warning is on a new line.
This PR captures the entire warning line except the trailing semicolon (which is crucial to anchoring the Rule regex).