Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding cisco_xr_show_ip_bgp_summary.template #170

Merged
merged 5 commits into from
Dec 26, 2017
Merged

adding cisco_xr_show_ip_bgp_summary.template #170

merged 5 commits into from
Dec 26, 2017

Conversation

Sandeepsr
Copy link
Contributor

ISSUE TYPE
  • New Template Pull Request
COMPONENT

adding cisco_xr_show_ip_bgp_summary.template

SUMMARY

adding cisco_xr_show_ip_bgp_summary.template

Sandeepsr
Sandeepsr commented Dec 19, 2017
View reviewed changes
Copy link
Contributor Author

@Sandeepsr Sandeepsr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixing the quotes

@itdependsnetworks
Copy link
Contributor

Can you take a look at: #167 and follow same recommendations?

Sandeepsr
Sandeepsr commented Dec 22, 2017
View reviewed changes
Copy link
Contributor Author

@Sandeepsr Sandeepsr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

adding ^$$ -> Error "LINE NOT FOUND" , also added ^\s*$$ instead of ^\s+$$ as it matches blank line and gives extra output with blank values

@itdependsnetworks
Copy link
Contributor

Take a look again at that other PR, it should end with

  ^\s+$$
  ^$$
  ^.* -> Error "LINE NOT FOUND"

@Sandeepsr
Copy link
Contributor Author

Sandeepsr commented Dec 22, 2017 •
edited
Loading

@itdependsnetworks , I tried that as well. it give me error : Error: "LINE NOT FOUND". Line: 18. , not sure what is causing that, can you check if you have time?

Sandeepsr
Sandeepsr commented Dec 22, 2017
View reviewed changes
Copy link
Contributor Author

@Sandeepsr Sandeepsr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updating : ^.* -> Error "LINE NOT FOUND" to template

@Sandeepsr
Copy link
Contributor Author

@itdependsnetworks , okay I have fixed that, please review now

@itdependsnetworks
Copy link
Contributor

Great, one last thing. Can you make state_prf... as just \S+ as that already contains \d+ within it

Sandeepsr
Sandeepsr commented Dec 23, 2017
View reviewed changes
Copy link
Contributor Author

@Sandeepsr Sandeepsr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update state_pfxrcd regex

@Sandeepsr
Copy link
Contributor Author

@itdependsnetworks , done

@itdependsnetworks itdependsnetworks merged commit df0e28a into networktocode:master Dec 26, 2017
jvanderaa pushed a commit that referenced this pull request Nov 10, 2021
@itdependsnetworks
Merge pull request #170 from Sandeepsr/sandeepsr/ntc1
b5e9c5b 
adding cisco_xr_show_ip_bgp_summary.template
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Sandeepsr @itdependsnetworks