Fix standard regular expressions to skip headers #169
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ISSUE TYPE
COMPONENT
templates/cisco_ios_show_mac-address-table.template
SUMMARY
So we had an issue with the below output as it would repeat the headers as part of the returned values.
The solution is to fix the regular expressions, as they would match too broad. For instance the expression
(\w+.\w+.\w+)
would match things likeA B C
orNightmare|On|ElmStreet
. Dots should be matched using\.
and for a mac-address the regexp could be much more strict.Same for vlan numbers we know it's between 1 and 4 digits.