Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update setup.py install_requires from gtextfsm->textfsm #150

Closed
wants to merge 5 commits into from

Conversation

johnarnold
Copy link

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT

setup

SUMMARY

Setup.py install_requires was referencing an old, unmaintained package. Updated to reference the current textfsm package.

@johnarnold
Copy link
Author

gtextfsm is way out of date. textfsm is current. gtextfsm implements module namespace, so imports have to change for textfsm.

@itdependsnetworks
Copy link
Contributor

I'll ping @jedelman8 on this one.

@sheffner1226
Copy link

Any update on this? Seems like it would be a good bug fix to implement.

@johnarnold
Copy link
Author

@itdependsnetworks @jedelman8 ping

@micahculpepper
Copy link
Contributor

textfsm was just updated and it looks like import changes in ntc_templates will no longer be necessary. Once textfsm releases the new version to PyPI, this should go smoothly.

I would suggest specifying a dependency on textfsm>=1.0.0 since their library went through a major API change.

@jmcgill298
Copy link
Contributor

#299 #300

@jmcgill298 jmcgill298 closed this Jan 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants