Fix aruba aoscx lldp issue1453 #1470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjbear
requested review from
itdependsnetworks,
jmcgill298 and
jvanderaa
as code owners
|
The troubleshooting on issue #1453 continues, there may be more changes necessary before this gets merged in. Thank you for holding off merging this PR. |
|
Ongoing troubleshooting. Hoping to determine today (9/8) if further changes are needed. |
mjbear
force-pushed
the
fix_aruba_aoscx_lldp_issue1453
branch
from
77bb130 to
8bc0f27
Compare
|
It appears that PR #1559 put in some of the fixes for Aruba's System/Chassis syntax change. |
mjbear
force-pushed
the
fix_aruba_aoscx_lldp_issue1453
branch
from
8bc0f27 to
1b6571b
Compare
mjbear
force-pushed
the
fix_aruba_aoscx_lldp_issue1453
branch
from
1b6571b to
095cf4b
Compare
|
fixing a bunch of merge conflicts 🤢 |
mjbear
force-pushed
the
fix_aruba_aoscx_lldp_issue1453
branch
from
095cf4b to
4d8521e
Compare
juniper_junos_show_lldp_neighbors to normalize
…co_ios_show_lldp_neighbors_detail
- replace REMOTE_MANAGEMENT_ADDRESS with MGMT_ADDRESS in hp_procurve_show_lldp_info_remote-device_detail - replace MGMT_ADDR with MGMT_ADDRESS in aruba_aoscx_show_lldp_neighbors-info_detail - replace MGMT_IP with MGMT_ADDRESS in cisco_nxos and cisco_xr cdp template - replace MANAGEMENT_IP with MGMT_ADDRESS in several templates Note: Chose not to include "IP" in the capture group name because Arista data sometimes includes Ethernet MAC addresses
mjbear
force-pushed
the
fix_aruba_aoscx_lldp_issue1453
branch
from
5001591 to
1d05f43
Compare
|
'lotta merge conflict resolution on this rebase ... thankfully done |
jmcgill298
approved these changes
Jul 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not caused by #1469 as that PR had not been merged when issue #1453 came in. 😅
Based off of #1469 and its modified capture group names so this PR should be merged last.
Update 2024/06/21:
Breaking change since the CDP/LLDP discovery protocol normalization shows up in this PR.
There's the real chance that #1469 may render this PR unnecessary. I'll rebase and find out. 😀