Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add data model documentation #1468

Closed
wants to merge 0 commits into from
Closed

add data model documentation #1468

wants to merge 0 commits into from

Conversation

mjbear
Copy link
Contributor

@mjbear mjbear commented Sep 2, 2023

Data model documentation to share guidance on capture group normalization.

@mjbear
Copy link
Contributor Author

mjbear commented Sep 2, 2023

@dainok
Here's a start on the data model for normalized capture group names. As you pointed out on #1405, CDP/LLDP is one that could be normalized. Although CDP/LLDP isn't normalized yet, I am working up a plan for the plethora of capture groups that match up with each other. 😁

If you're interested in weighing in on the CDP/LLDP I could copy you in.

@mjbear mjbear mentioned this pull request Sep 4, 2023
Merged
@dainok
Copy link
Contributor

dainok commented Sep 9, 2023

@dainok Here's a start on the data model for normalized capture group names. As you pointed out on #1405, CDP/LLDP is one that could be normalized. Although CDP/LLDP isn't normalized yet, I am working up a plan for the plethora of capture groups that match up with each other. 😁

If you're interested in weighing in on the CDP/LLDP I could copy you in.

Yes please (sorry for the late response)

@mjbear
Copy link
Contributor Author

mjbear commented Sep 9, 2023

@dainok Here's a start on the data model for normalized capture group names. As you pointed out on #1405, CDP/LLDP is one that could be normalized. Although CDP/LLDP isn't normalized yet, I am working up a plan for the plethora of capture groups that match up with each other. 😁
If you're interested in weighing in on the CDP/LLDP I could copy you in.

Yes please (sorry for the late response)

@dainok
Please give PR #1469 a look if you have time.

This was referenced Dec 28, 2023
Merged
Merged
@mjbear mjbear closed this Jan 7, 2024
@mjbear
Copy link
Contributor Author

mjbear commented Jan 7, 2024

Did I accidentally close this?

@jvanderaa
Copy link
Contributor

It was tied to #1582

@mjbear mjbear deleted the docs_data_model branch June 22, 2024 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@itdependsnetworks itdependsnetworks Awaiting requested review from itdependsnetworks

@jmcgill298 jmcgill298 Awaiting requested review from jmcgill298

@jvanderaa jvanderaa Awaiting requested review from jvanderaa

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mjbear @dainok @jvanderaa