Added new template: show interface link on cisco ios #1290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This has different outputs on several platforms
jversch6
requested review from
itdependsnetworks,
jmcgill298 and
jvanderaa
as code owners
| ^\s*${PORT}\s+${DOWNTIME}\s*${SINCE}\s*$$ -> Record | ||
| ^\s*${PORT}\s+${NAME}\s*${DOWNTIME}\s*$$ -> Record | ||
| ^\s*${PORT}\s+${NAME}\s*${DOWNTIME}\s+${SINCE}\s*$$ -> Record | ||
|
|
There was a problem hiding this comment.
Can you add:
^\s*$$
^. -> Error
| UpTime | ||
| ^\s*${PORT}\s+${NAME}\s+00:00:00\s+${UPTIME}?\s*$$ -> Record | ||
| ^\s*${PORT}\s+${DOWNTIME}\s+${UPTIME}?\s*$$ -> Record | ||
| ^\s*${PORT}\s+${NAME}\s+${DOWNTIME}\s*$$ -> Record |
There was a problem hiding this comment.
Can you add:
^\s*$$
^. -> Error
| Port Name Down Time Down Since | ||
| Gi1/1 37 weeks, 3 days, 5 hours, 52 minutes 18 secs 08:07:10 Mon Feb 14 2022 | ||
| Gi1/6 15 weeks, 11 minutes 57 secs 13:47:31 Thu Jul 21 2022 | ||
| Gi1/10 Fitness 10 weeks, 5 days, 20 hours, 26 minutes 38 secs 17:32:50 Fri Aug 19 2022 |
There was a problem hiding this comment.
Is it possible for their to be spaces here? e.g. ICE Port
There was a problem hiding this comment.
Added test case and cleaned up some redundant lines.
|
@jversch6 thanks for including the Error line, but I think the templates are not matching all of the output, and the tests are failing. |
|
@jmcgill298 Sorry, apparently I hadn't committed the .raw file . It's showing green now! |
|
@itdependsnetworks @jmcgill298 we good here? |
|
Thanks @jversch6 |
pszulczewski
pushed a commit
that referenced
this pull request
Apr 12, 2023
cppmonkey
pushed a commit
to cppmonkey/ntc-templates
that referenced
this pull request
Oct 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has different outputs on several platforms and often doesn't return some fields at all, hence the multitude of configurations.